- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: fix deployment settings navigation issues#16780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
buenos-nachos left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Did the initial review – going to spin up the branch and verify everything else
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
buenos-nachos commentedMar 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
buenos-nachos left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Approving tentatively, since I didn't find anything major
Uh oh!
There was an error while loading.Please reload this page.
17ad284 intomainUh oh!
There was an error while loading.Please reload this page.
stirby commentedMar 3, 2025
Thank you@aslilac @Parkreiner |
stirby commentedMar 3, 2025
/cherry-pick release/2.20 |

As discussed, a minimal patch that fixes some issues discovered at the last hour of the Orgs GA work:
DeploymentSettingsLayoutcomponent may lock you out entirely, incorrectly, because of a bad permission check on the front end