- Notifications
You must be signed in to change notification settings - Fork1.2k
chore: track workspace resource monitors in telemetry#16776
Merged
Conversation
73bafaf to70900ccCompareContributorAuthor
hugodutka commentedMar 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
One idea after thinking about the queries here again: maybe it'd be better to use the updated at value rather than created at for fetching the monitors? We'd then also get telemetry updates whenever the monitors are updated. |
Uh oh!
There was an error while loading.Please reload this page.
defelmnq approved these changesMar 3, 2025
Contributor
defelmnq left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just a comment which is more a question than a blocker - but all good !
Thanks a lot@hugodutka 🔥
Collaborator
stirby commentedMar 3, 2025
/cherry-pick release/2.20 |
70900cc tob92060aCompareContributorAuthor
hugodutka commentedMar 3, 2025
Updated the queries to use |
24f3445 intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
gcp-cherry-pick-botbot pushed a commit that referenced this pull requestMar 3, 2025
Addressescoder/nexus#195. Specifically, justthe "tracking templates" requirement:> ## Tracking in templates> To enable resource alerts, a user must add the resource_monitoringblock to a template's coder_agent resource. We'd like to track ifcustomers have any resource monitoring enabled on a per-deploymentbasis. Even better, we could identify which templates are using resourcemonitoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Addresseshttps://github.com/coder/nexus/issues/195. Specifically, just the "tracking templates" requirement: