Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: track workspace resource monitors in telemetry#16776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 4 commits intomainfromhugodutka/resource-monitor-telemetry
Mar 3, 2025

Conversation

@hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedMar 3, 2025•
edited
Loading

Addresseshttps://github.com/coder/nexus/issues/195. Specifically, just the "tracking templates" requirement:

Tracking in templates

To enable resource alerts, a user must add the resource_monitoring block to a template's coder_agent resource. We'd like to track if customers have any resource monitoring enabled on a per-deployment basis. Even better, we could identify which templates are using resource monitoring.

@hugodutkahugodutkaforce-pushed thehugodutka/resource-monitor-telemetry branch from73bafaf to70900ccCompareMarch 3, 2025 15:46
@hugodutkahugodutka marked this pull request as ready for reviewMarch 3, 2025 16:03
@hugodutkahugodutka requested a review fromdefelmnqMarch 3, 2025 16:03
@hugodutka
Copy link
ContributorAuthor

hugodutka commentedMar 3, 2025•
edited
Loading

One idea after thinking about the queries here again: maybe it'd be better to use the updated at value rather than created at for fetching the monitors? We'd then also get telemetry updates whenever the monitors are updated.

Copy link
Contributor

@defelmnqdefelmnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a comment which is more a question than a blocker - but all good !

Thanks a lot@hugodutka 🔥

hugodutka reacted with thumbs up emoji
@stirby
Copy link
Collaborator

/cherry-pick release/2.20

@hugodutkahugodutkaforce-pushed thehugodutka/resource-monitor-telemetry branch from70900cc tob92060aCompareMarch 3, 2025 17:27
@hugodutka
Copy link
ContributorAuthor

Updated the queries to useupdated_at instead ofcreated_at as explained in#16776 (comment).

@hugodutkahugodutka merged commit24f3445 intomainMar 3, 2025
30 checks passed
@hugodutkahugodutka deleted the hugodutka/resource-monitor-telemetry branchMarch 3, 2025 17:41
gcp-cherry-pick-botbot pushed a commit that referenced this pull requestMar 3, 2025
Addressescoder/nexus#195. Specifically, justthe "tracking templates" requirement:> ## Tracking in templates> To enable resource alerts, a user must add the resource_monitoringblock to a template's coder_agent resource. We'd like to track ifcustomers have any resource monitoring enabled on a per-deploymentbasis. Even better, we could identify which templates are using resourcemonitoring.
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@defelmnqdefelmnqdefelmnq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hugodutkahugodutka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugodutka@stirby@defelmnq
[8]ページ先頭
©2009-2025 Movatter.jp