Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: perform several small frontend permissions refactors#16735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 4 commits intomainfromlilac/e2e-button-checks
Mar 7, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedFeb 27, 2025•
edited
Loading

A bunch of small changes that I made while fixing bugs and cleaning up permissions code, but that couldn't get merged as part of the bigger PR out of risk of creating too much noise when cherry picking to the release branches.

@aslilacaslilac changed the titletests: add more e2e orgs teststest: add more e2e orgs testsFeb 27, 2025
@aslilacaslilac changed the titletest: add more e2e orgs testschore: several small frontend permissions refactorsMar 5, 2025
@aslilacaslilac changed the titlechore: several small frontend permissions refactorschore: perform several small frontend permissions refactorsMar 5, 2025
@aslilacaslilac marked this pull request as ready for reviewMarch 5, 2025 21:41
@aslilacaslilacforce-pushed thelilac/e2e-button-checks branch from4d9ec85 toe98ccd3CompareMarch 6, 2025 00:29
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I really enjoyed the changes 🙏

});

asyncfunctionresetSearch(page:Page){
asyncfunctionresetSearch(page:Page,username:string){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: I think a better name for this function could befilterByUser orsearchByUser.

Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@aslilacaslilacforce-pushed thelilac/e2e-button-checks branch fromfe9bbea toee5013fCompareMarch 7, 2025 17:06
@aslilacaslilac merged commit092c129 intomainMar 7, 2025
33 checks passed
@aslilacaslilac deleted the lilac/e2e-button-checks branchMarch 7, 2025 17:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@jaaydenhjaaydenhjaaydenh approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aslilac@jaaydenh@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp