- Notifications
You must be signed in to change notification settings - Fork914
fix(vpn): fail early if wintun.dll is not present#16707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ethanndickson approved these changesFeb 26, 2025
sreya approved these changesFeb 27, 2025
b23e05b intomain 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
/cherry-pick release/2.20 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the VPN startup from hanging for 5 minutes due to a startup backoff if
wintun.dllcannot be loaded.Because the
wintunpackage doesn't expose an easyLoad() errormethod for us, the only way for us to force it to load (without unwanted side effects) is throughwintun.Version()which doesn't return an error message.So, we call that function so the
wintunpackage loads the DLL and configures the logging properly, then we try to load the DLL ourselves.LoadLibraryExwill not load the library multiple times and returns a reference to the existing library.Closescoder/coder-desktop-windows#24