Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: include winres metadata in Windows binaries#16706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 6 commits intomainfromdean/winres
Feb 28, 2025

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedFeb 26, 2025•
edited
Loading

Adds information like product/file version, description, product name and copyright to compiled Windows binaries in dogfood and release builds. Also adds an icon to the executable.

This is necessary for Coder Desktop to be able to check the version on binaries.

Before:

image
image

After:

image
image
image

Closes#16693

Adds information like product/file version, description, product nameand copyright to compiled Windows binaries in dogfood and releasebuilds.
@deansheather
Copy link
MemberAuthor

Seems to work in the build job

ethanndickson and sreya reacted with hooray emoji

@deansheather
Copy link
MemberAuthor

Tested in the release job and it seems to work. Unfortunately I can't really test whether the binaries will have(development build) in the description andx.y.z.1 instead ofx.y.z.0 as the assembly version unless it's a real build.

@deansheatherdeansheather merged commit64fec8b intomainFeb 28, 2025
40 checks passed
@deansheatherdeansheather deleted the dean/winres branchFebruary 28, 2025 05:03
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 28, 2025
@matifali
Copy link
Member

/cherry-pick release/2.20

1 similar comment
@matifali
Copy link
Member

/cherry-pick release/2.20

@matifalimatifali restored the dean/winres branchFebruary 28, 2025 07:25
@matifalimatifali deleted the dean/winres branchFebruary 28, 2025 08:47
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@sreyasreyaAwaiting requested review from sreya

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows binaries should contain product version, slim binaries should be signed
3 participants
@deansheather@matifali@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp