- Notifications
You must be signed in to change notification settings - Fork907
feat: support session audit log#16703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@mafredri open questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
From a BE/implementation perspective, this LGTM!
site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| return ( | ||
| <Pill | ||
| css={styles.statusCodePill} | ||
| type={isHttp ? httpStatusColor(code) : code === 0 ? "success" : "error"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice fix for this!
| @@ -232,6 +227,19 @@ export const AuditLogRow: FC<AuditLogRowProps> = ({ | |||
| ); | |||
| }; | |||
| function StatusPill({ code }: { code: number }) { | |||
| const isHttp = code >= 100; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, a better measure of http status code may be whether or not this was a connect/disconnect action. Shell errors can be 0-255, but perhaps we should just mark them as 0/1 on the API side, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hm... I think it works 👍
…LogDescription.tsxCo-authored-by: Mathias Fredriksson <mafredri@gmail.com>
f1b357d intomainUh oh!
There was an error while loading.Please reload this page.
Related to#15139
Demo:
