Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add helper text to unauthorized error messages#1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 10 commits intomainfrom917-bug-cleaner-error-message
May 23, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedMay 23, 2022•
edited
Loading

Adds a suggestion to login in the error messages for users when receiving unauthorized errors.

Subtasks:

  • Handle authorization errors due to the absence of url/session files
  • Handle authorization errors due to incorrect session key
  • Add unit tests

Fixes#917

@AbhineetJainAbhineetJain requested a review fromEmyrkMay 23, 2022 16:20
@AbhineetJainAbhineetJain requested a review fromEmyrkMay 23, 2022 17:59
@AbhineetJainAbhineetJain marked this pull request as ready for reviewMay 23, 2022 18:00
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor nit. LG!

@AbhineetJainAbhineetJain merged commit4a78bad intomainMay 23, 2022
@AbhineetJainAbhineetJain deleted the 917-bug-cleaner-error-message branchMay 23, 2022 18:51
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* add helper text to unauthorized error messages* fix lint error, add unit tests* fix test name* fix test name* fix lint errors in test* add unauthorized test for templates create* remove unnecessary variable* remove Error struct, change error message* change [url] to <url>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: cleaner error message for non logged-in user
2 participants
@AbhineetJain@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp