Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: hide app icon if not found#16684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 4 commits intomainfrom14759-app
Feb 25, 2025
Merged

fix: hide app icon if not found#16684

mtojek merged 4 commits intomainfrom14759-app
Feb 25, 2025

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedFeb 24, 2025•
edited
Loading

Fixes:#14759

This PR dynamically hides icon's<img> tag if the image can't be loaded (HTTP 404).

Screenshot 2025-02-24 at 17 08 25Screenshot 2025-02-25 at 11 20 56

@mtojekmtojek self-assigned thisFeb 24, 2025
@mtojekmtojek marked this pull request as ready for reviewFebruary 24, 2025 16:22
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but deferring to the FE expert here!

@matifali
Copy link
Member

Can we also show a warning somewhere to let the user know that the path used is incorrect? I am not sure what is the best place to show the warning.

  1. Toast notification?
  2. In logs?
  3. Developer Console.?

@mtojek
Copy link
MemberAuthor

@matifali This is strictly in the browser, so we don't have too many options. As a Coder user, I wouldn't like to see some toasts, but I believe we could drop a singleconsole.log

johnstcn and matifali reacted with thumbs up emoji

@mtojekmtojekenabled auto-merge (squash)February 25, 2025 10:22
@mtojekmtojek merged commita2d4b99 intomainFeb 25, 2025
30 of 32 checks passed
@mtojekmtojek deleted the 14759-app branchFebruary 25, 2025 10:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@matifalimatifalimatifali approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle invalid and nonexistent icon paths incoder_app
3 participants
@mtojek@matifali@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp