- Notifications
You must be signed in to change notification settings - Fork909
docs: document default GitHub OAuth2 configuration and device flow#16663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
da04e13
to1bd4a54
Compare2788eb5
toeb41f65
Compare59d6043
tofb471f9
Compare032150d
to9a15225
Compare9a15225
to407cdd3
Comparefb471f9
toda869e0
CompareLet's wait before merging this: I'm actually not sure if Coder the company gets the accesses I outlined. I'll double check and confirm by Friday. |
da869e0
tob7ea9ae
Compare071d6cc
to1720441
Compared8a0541
to34d6000
Compare1720441
to297e90b
Compareb060a1e
to0ade9a2
Comparehugodutka commentedFeb 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@EdwardAngert I checked and I believe the company doesn't get access to the data after all. I added the "to the best of our knowledge" disclaimer because GitHub documentation doesn't directly say an app's administrator doesn't get access. I looked and as far as I can tell, it doesn't specify a way to get this data, and I wasn't able to obtain it in my testing. I can't point to a specific piece of documentation that says it can't be done, so there might be a way I'm not aware of. GitHub only lets the app administrator see users who use its app if the userinstalls it in their account, but in the login process the Coder serverauthenticates with the GitHub app on behalf of the user instead. Let me know if the copy looks good to you. |
0ade9a2
tof77b54b
Comparef77b54b
toebd0a93
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
a5842e5
intomainUh oh!
There was an error while loading.Please reload this page.
/cherry-pick release/2.20 |
Document the changes made in#16629 and#16585.