Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: document default GitHub OAuth2 configuration and device flow#16663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 1 commit intomainfromhugodutka/github-oauth2-docs
Mar 3, 2025

Conversation

hugodutka
Copy link
Contributor

Document the changes made in#16629 and#16585.

@hugodutkahugodutka changed the titledocs: default GitHub OAuth2 configuration and device flowdocs: document default GitHub OAuth2 configuration and device flowFeb 22, 2025
@hugodutkahugodutka marked this pull request as ready for reviewFebruary 23, 2025 18:06
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch 2 times, most recently fromda04e13 to1bd4a54CompareFebruary 24, 2025 13:55
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-default branch from2788eb5 toeb41f65CompareFebruary 24, 2025 16:19
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch 3 times, most recently from59d6043 tofb471f9CompareFebruary 24, 2025 16:59
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-default branch from032150d to9a15225CompareFebruary 24, 2025 16:59
@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelFeb 24, 2025
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-default branch from9a15225 to407cdd3CompareFebruary 24, 2025 18:03
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch fromfb471f9 toda869e0CompareFebruary 24, 2025 18:03
@hugodutka
Copy link
ContributorAuthor

Let's wait before merging this: I'm actually not sure if Coder the company gets the accesses I outlined. I'll double check and confirm by Friday.

@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch fromda869e0 tob7ea9aeCompareFebruary 24, 2025 20:37
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-default branch 2 times, most recently from071d6cc to1720441CompareFebruary 24, 2025 20:57
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch 2 times, most recently fromd8a0541 to34d6000CompareFebruary 25, 2025 15:16
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-default branch from1720441 to297e90bCompareFebruary 25, 2025 15:16
Base automatically changed fromhugodutka/github-oauth2-default tomainFebruary 25, 2025 15:31
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch 3 times, most recently fromb060a1e to0ade9a2CompareFebruary 28, 2025 17:22
@hugodutka
Copy link
ContributorAuthor

hugodutka commentedFeb 28, 2025
edited
Loading

@EdwardAngert I checked and I believe the company doesn't get access to the data after all. I added the "to the best of our knowledge" disclaimer because GitHub documentation doesn't directly say an app's administrator doesn't get access. I looked and as far as I can tell, it doesn't specify a way to get this data, and I wasn't able to obtain it in my testing. I can't point to a specific piece of documentation that says it can't be done, so there might be a way I'm not aware of.

GitHub only lets the app administrator see users who use its app if the userinstalls it in their account, but in the login process the Coder serverauthenticates with the GitHub app on behalf of the user instead.

Let me know if the copy looks good to you.

@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch from0ade9a2 tof77b54bCompareFebruary 28, 2025 17:31
@hugodutkahugodutkaforce-pushed thehugodutka/github-oauth2-docs branch fromf77b54b toebd0a93CompareFebruary 28, 2025 17:52
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@hugodutkahugodutka merged commita5842e5 intomainMar 3, 2025
28 checks passed
@hugodutkahugodutka deleted the hugodutka/github-oauth2-docs branchMarch 3, 2025 11:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 3, 2025
@stirby
Copy link
Collaborator

/cherry-pick release/2.20

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@EdwardAngertEdwardAngertAwaiting requested review from EdwardAngert

Assignees

@hugodutkahugodutka

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hugodutka@stirby@matifali@EdwardAngert

[8]ページ先頭

©2009-2025 Movatter.jp