Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: runmake clean on workspace startup#16660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromlilac/make-clean-on-shutdown
Feb 24, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedFeb 21, 2025
edited
Loading

I originally thought usingshutdown_script would be better, but after some testing it seems likeshutdown_scripts don't get run nearly as consistently. Idk what's going on there, but running this on startup shouldn't be too bad because it should always be fast, at least.

Our various build outputs can easily take up dozens of gigabytes per workspace. Multiply that across dozens of engineers, and it's considerable. We've been seeing a lot of disk utilization warnings lately because some of our disks are getting "too" full (even though in reality they often have hundreds of gigabytes of spare capacity). This is an easy way to quiet those warnings, and leave us with plenty of capacity to onboard additional engineers without needing to upgrade our actual storage resources.

Also bumps threshold to 90%, because realistically that's still aton of spare capacity.

@aslilacaslilac changed the titlechore: runmake clean on workspace shutdownchore: runmake clean on workspace startupFeb 21, 2025
@aslilacaslilac marked this pull request as ready for reviewFebruary 21, 2025 22:20
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we move this to acoder_script withrun_on_stop = true.

@aslilac
Copy link
MemberAuthor

in my testing,run_on_stop just never runs at all. :\ I agree that it would be better there, but it also wouldn't do anything.

can we fixrun_on_stop andthen do that? I agree we should be dogfooding it, but if we did it right now this pr would do nothing

matifali reacted with thumbs up emoji

@aslilacaslilac merged commitdfa33b1 intomainFeb 24, 2025
37 checks passed
@aslilacaslilac deleted the lilac/make-clean-on-shutdown branchFebruary 24, 2025 17:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 24, 2025
@matifali
Copy link
Member

@aslilac can you create an issue with your experience withrun_on_stop? Thanks.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@matifali

[8]ページ先頭

©2009-2025 Movatter.jp