- Notifications
You must be signed in to change notification settings - Fork928
chore: runmake clean
on workspace startup#16660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
make clean
on workspace shutdownmake clean
on workspace startupThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we move this to acoder_script
withrun_on_stop = true
.
in my testing, can we fix |
dfa33b1
intomainUh oh!
There was an error while loading.Please reload this page.
@aslilac can you create an issue with your experience with |
Uh oh!
There was an error while loading.Please reload this page.
I originally thought using
shutdown_script
would be better, but after some testing it seems likeshutdown_script
s don't get run nearly as consistently. Idk what's going on there, but running this on startup shouldn't be too bad because it should always be fast, at least.Our various build outputs can easily take up dozens of gigabytes per workspace. Multiply that across dozens of engineers, and it's considerable. We've been seeing a lot of disk utilization warnings lately because some of our disks are getting "too" full (even though in reality they often have hundreds of gigabytes of spare capacity). This is an easy way to quiet those warnings, and leave us with plenty of capacity to onboard additional engineers without needing to upgrade our actual storage resources.
Also bumps threshold to 90%, because realistically that's still aton of spare capacity.