Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add provisioner tags field on template creation#16656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 5 commits intomainfrombq/add-provisioner-tags-field
Feb 25, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedFeb 21, 2025•
edited
Loading

Close#15426

Demo:

Screen.Recording.2025-02-20.at.16.16.41.mov

@BrunoQuaresmaBrunoQuaresma requested a review froma teamFebruary 21, 2025 17:43
@BrunoQuaresmaBrunoQuaresma self-assigned thisFeb 21, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromjaaydenh and removed request fora teamFebruary 21, 2025 17:43
@jaaydenh
Copy link
Contributor

@BrunoQuaresma Is the design for the provisioner tags based off of anything in Figma? If not it seems like it would be good to follow a pattern present in the Badges in Coder Kit in FIgma,https://www.figma.com/design/WfqIgsTFXN2BscBSSyXWF8/Coder-kit?node-id=489-3472&m=dev

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm afraid it is pending too long on fe review so unblocking Bruno.

BrunoQuaresma reacted with heart emoji
@BrunoQuaresma
Copy link
CollaboratorAuthor

@BrunoQuaresma Is the design for the provisioner tags based off of anything in Figma? If not it seems like it would be good to follow a pattern present in the Badges in Coder Kit in FIgma,https://www.figma.com/design/WfqIgsTFXN2BscBSSyXWF8/Coder-kit?node-id=489-3472&m=dev

We didn't create a design for this one since redesign forms are a larger effort by itself so we decided to keep using the current components - the component is the same one used in the template editor with a few refactoring.

@BrunoQuaresma
Copy link
CollaboratorAuthor

I got a feedback from@matifalihere. It should be a quick fix.

mtojek reacted with rocket emoji

@github-actionsGitHub Actions
Copy link

🚀 Deploying PR 16656 ...

github-actions[bot] reacted with eyes emoji

@BrunoQuaresmaBrunoQuaresma merged commit38ad8d1 intomainFeb 25, 2025
30 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-provisioner-tags-field branchFebruary 25, 2025 17:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@jaaydenhjaaydenhAwaiting requested review from jaaydenhjaaydenh was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(site): no way to set workspace_tags when importing a starter template
3 participants
@BrunoQuaresma@jaaydenh@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp