Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: Move schedule info to the sidebar#1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/add-workspace-sidebar
May 23, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedMay 23, 2022
edited
Loading

Screen Shot 2022-05-23 at 11 20 35

@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerMay 23, 2022 14:22
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 23, 2022
@BrunoQuaresma
Copy link
CollaboratorAuthor

cc.:@vapurrmaid

@ammario
Copy link
Member

I agree with the need to cleanly separate the schedule from the status bar. The new column looks odd to me, because I think that every item in a column would follow some consistent theme. I can't think of other items to put in that column that would relate to auto start, though.

@BrunoQuaresma
Copy link
CollaboratorAuthor

@ammario yes, I agree. I could not think of a better place to put the schedule info tho. Also, I think the sidebar can be a good place to add more "info" in the future if we need it like this:

Screen Shot 2022-05-23 at 11 32 56

@ammario
Copy link
Member

Gotcha@BrunoQuaresma. It seems fine to me. Why did you remove the background format from the panels? I think the consistency between the panel and Timeline styles looked good.

@BrunoQuaresma
Copy link
CollaboratorAuthor

@ammario it is just an old screenshot from a Figma file that I haven't updated yet.

@BrunoQuaresmaBrunoQuaresma merged commit9f3a6d6 intomainMay 23, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-workspace-sidebar branchMay 23, 2022 14:41
@ammario
Copy link
Member

Sorry, I meant the Schedule panel as well. I think it should have a background for consistency.
image

@BrunoQuaresma
Copy link
CollaboratorAuthor

I see, I think adding a background to it will make the design looks very blocked, but I will play around with this idea. I've been using the GitHub sidebar as a reference.

Screen Shot 2022-05-23 at 13 51 53

@ammario
Copy link
Member

GitHub is an interesting case study. I think the horizontal separators can do a lot for the design.

@misskniss
Copy link

fixes#1661

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@BrunoQuaresma@ammario@misskniss@greyscaled

[8]ページ先頭

©2009-2025 Movatter.jp