Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: include a link and more useful error details for 403 response codes#16644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

brettkolodny
Copy link
Contributor

Currently if a user gets to a page they don't have permission to view they're greeted with a vague error alert and no actionable items. This PR adds a link back to/workspaces within the alert as well as more helpful error details.

Before:
Screenshot 2025-02-20 at 11 06 06 AM

After:
Screenshot 2025-02-20 at 11 06 19 AM

@brettkolodnybrettkolodny changed the titlefix: include a link to /workspaces and more useful error details for 403 response codesfix: include a link and more useful error details for 403 response codesFeb 20, 2025
@brettkolodnybrettkolodny marked this pull request as draftFebruary 20, 2025 17:49
@brettkolodnybrettkolodny marked this pull request as ready for reviewFebruary 21, 2025 20:31
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

⛳️

@@ -154,6 +154,7 @@ func ResourceNotFound(rw http.ResponseWriter) {
func Forbidden(rw http.ResponseWriter) {
Write(context.Background(), rw, http.StatusForbidden, codersdk.Response{
Message: "Forbidden.",
Detail: "You don't have permission to view this page. If you believe this is a mistake, please contact your administrator or try signing in with different credentials.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Detail:"You don't have permission to view thispage. If you believe this is a mistake, please contact your administrator or try signing in with different credentials.",
Detail:"You don't have permission to view thiscontent. If you believe this is a mistake, please contact your administrator or try signing in with different credentials.",

thinking of this in the context of using the CLI or the API directly, "page" doesn't make a ton of sense

<>
<AlertTitle>{message}</AlertTitle>
<AlertDetail>
{detail}{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know theoretically we're now always settingDetail for 403 responses, but what if it comes back undefined from some endpoint that doesn't usehttpapi.Forbidden when it should? do we care about handling that? maybe we don't and it's fine 🤷‍♀️

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Just had one main question


return (
<Alert severity="error" {...alertProps}>
{body()}
Copy link
Member

@ParkreinerParkreinerFeb 21, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: I don't know your opinion on ternaries, but I feel like the typical React way of doing this would be to inline everything into a single return statement:

return(<Alertseverity="error"{...alterProps}>{status===403      ?(<--JSX-->)      :detail ?(<--JSX-->)      :(message)</Alert>);

Prettier/Biome should be able to format the ternaries to make them more readable than this, but you get the idea

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm usually pro ternary but I've been trying to match other general vibes of the code base. Generally though I think I've started to learn towards if the logic is more than an "if/else" it's more readable being broken out

// Additionally since the error messages and details from the server can be
// missing or confusing for an end user we render a friendlier message
// regardless of the response from the server.
if (status === 403) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm okay with this as a baseline solution, but do you know if there are ever cases where it makes sense to redirect the user to a page more relevant to what they were trying to access?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah I agree, and I'm actually working on a PR right now that will makeRequirePermissions a bit more user friendly in that way. But this change is still relevant in the cases where we don't wrap a portion of the page inRequirePermissions

@brettkolodnybrettkolodny merged commita376e8d intomainFeb 21, 2025
33 checks passed
@brettkolodnybrettkolodny deleted the brett/improve-erroralert-to-include-a-redirect-button branchFebruary 21, 2025 21:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@brettkolodnybrettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@brettkolodny@aslilac@Parkreiner

[8]ページ先頭

©2009-2025 Movatter.jp