Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd): avoid fetching extra parameters for a preset#16642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 1 commit intomainfromjjs/presets-extra-params-bug
Feb 20, 2025

Conversation

SasSwart
Copy link
Contributor

This pull request fixes a bug in presets and adds tests to ensure it doesn't happen again.
Due to an oversight in refactoring, we returned extra and incorrect parameters from other presets in the same template version when calling/templateversions/{templateversion}/presets.

@SasSwartSasSwart marked this pull request as ready for reviewFebruary 20, 2025 06:35
@SasSwartSasSwart merged commitdedc32f intomainFeb 20, 2025
34 checks passed
@SasSwartSasSwart deleted the jjs/presets-extra-params-bug branchFebruary 20, 2025 07:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SasSwart@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp