Movatterモバイル変換

Skip to content

coder/coderPublic

NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

fix!: enforce regex for agent names#16641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

deansheather merged 2 commits intomainfromdean/agent-name-regex

Feb 20, 2025

Merged

fix!: enforce regex for agent names#16641

deansheather merged 2 commits intomainfromdean/agent-name-regex

Feb 20, 2025

Conversation

deansheather

Copy link

Member

deansheather commentedFeb 20, 2025•
edited by ethanndickson
Loading

Underscores and trailing, leading and double hyphens are now blocked. The regex is almost the exact same as thecoder_appslug regex, but uppercase characters are still permitted.

@deansheather

fix!: enforce regex for agent names

d2c3a14

Underscores and double hyphens are now blocked. The regex is almost theexact same as the `coder_app` `slug` regex, but uppercase characters arestill permitted.

@deansheather

deansheather added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process label

@deansheather

deansheather requested review fromethanndickson andhugodutka

February 20, 2025 04:26

@deansheather

deansheather self-assigned this

ethanndickson

ethanndickson approved these changes

View reviewed changes

Copy link

Member

ethanndickson left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm after a lint!
I like that we have a clear error message on what changed.

provisioner/terraform/resources.go

Comment on lines +219 to +221

		iftfResource.Name=="" {
		returnnil,xerrors.Errorf("agent name cannot be empty")
		}

Copy link

Member

ethanndicksonFeb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is technically already checked for us by Terraform, but I think it's fine to check again?

Copy link

Member

ethanndicksonFeb 20, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess in case we ever change how we extract the name it's good to have

@deansheather

fixup! fix!: enforce regex for agent names

d247016

@deansheather

deansheatherenabled auto-merge (squash)

February 20, 2025 04:56

@deansheather

deansheather merged commit9469b78 intomain

33 checks passed

@deansheather

deansheather deleted the dean/agent-name-regex branch

February 20, 2025 05:09

@github-actions

github-actionsbot locked and limited conversation to collaborators

@matifali

Copy link

Member

matifali commentedFeb 20, 2025

@ethanndickson @stirby, we need to call this out in the changelog.

@ethanndickson

Copy link

Member

ethanndickson commentedFeb 20, 2025

Yep, this and#16614 are both annotated with the breaking tag

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Labels

release/breaking

This label is applied to PRs to detect breaking changes as part of the release process

3 participants

@deansheather

@matifali

@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp