- Notifications
You must be signed in to change notification settings - Fork928
chore(dogfood): add validation on OOM OOD parameters#16636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a quick fix but shouldn't we handle this as part of the resource_monitoring?
Or by broken build you meant that it is correctly handled already we just need to make sure someone doesn't enter those out of bound values.
It's handled by the provider; breaking the build in this case means hitting validation errors I would assume. https://github.com/coder/terraform-provider-coder/blob/main/provider/agent.go#L291 Side-note: it would be good to surface these validations in the FE so we don't allow form submissions with invalid data. It's quite a lift, though. |
Yep@dannykopping - to confirm this is breaking during the build which is what I would expect. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Thanks for the explanation,@dannykopping and@defelmnq. |
10326b4 intomainUh oh!
There was an error while loading.Please reload this page.
You can break the build by setting
N < 0orN > 100.