Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(agent): add second SSH listener on port 22#16627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedFeb 19, 2025•
edited
Loading

Fixes:coder/internal#377

Added an additional SSH listener on port 22, so the agent now listens on both, port one and port 22.

Change-Id: Ifd986b260f8ac317e37d65111cd4e0bd1dc38af8
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedFeb 19, 2025•
edited
Loading

@ThomasK33ThomasK33 marked this pull request as ready for reviewFebruary 19, 2025 17:51
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch from819a0fe to959eb23CompareFebruary 19, 2025 18:58
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation branch fromf744aa5 tod74cb78CompareFebruary 19, 2025 18:58
@ThomasK33ThomasK33 marked this pull request as draftFebruary 20, 2025 09:33
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation branch fromd74cb78 to38f9dfcCompareFebruary 20, 2025 11:16
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch from959eb23 to7a2f8ddCompareFebruary 20, 2025 11:16
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch from7a2f8dd to9355b33CompareFebruary 20, 2025 12:53
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation branch 2 times, most recently fromcab51d9 to9c85cdeCompareFebruary 20, 2025 16:10
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch 2 times, most recently from72fddd1 toafb4ca0CompareFebruary 20, 2025 16:17
@ThomasK33ThomasK33 changed the titlefix(tailnet): update WorkspaceAgentSSHPort to 22feat(agent): add an additional SSH listener on port 22Feb 20, 2025
@ThomasK33ThomasK33 changed the titlefeat(agent): add an additional SSH listener on port 22feat(agent): add second SSH listener on port 22Feb 20, 2025
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch fromafb4ca0 tocca709aCompareFebruary 20, 2025 16:41
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation branch from9c85cde to658db5aCompareFebruary 21, 2025 10:33
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch 2 times, most recently from2cb3669 to650520dCompareFebruary 21, 2025 12:40
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation branch from658db5a tod0206e7CompareFebruary 21, 2025 12:40
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch from650520d to0777db7CompareFebruary 21, 2025 12:52
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation branch fromd0206e7 toad275dcCompareFebruary 21, 2025 13:06
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch from0777db7 tof674d83CompareFebruary 21, 2025 13:06
@ThomasK33ThomasK33 marked this pull request as ready for reviewFebruary 21, 2025 13:08
@ThomasK33ThomasK33 changed the base branch fromthomask33/02-19-fix_agentssh_pin_random_seed_for_rsa_key_generation tographite-base/16627February 21, 2025 13:58
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch fromf674d83 toa2ce9b2CompareFebruary 21, 2025 13:58
@ThomasK33ThomasK33 changed the base branch fromgraphite-base/16627 tomainFebruary 21, 2025 13:59
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch froma2ce9b2 toc9c1602CompareFebruary 21, 2025 13:59
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In our meeting I vaguely recall talking about if we could have the ssh daemon listen on port 22only for the tailnet interface, as to not interfere with any others running on the workspace. Is that implicit in this change?

Copy link
Contributor

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but needs a test.

ThomasK33 reacted with thumbs up emoji
@ThomasK33
Copy link
MemberAuthor

In our meeting I vaguely recall talking about if we could have the ssh daemon listen on port 22only for the tailnet interface, as to not interfere with any others running on the workspace. Is that implicit in this change?

We're explicitly doing this by usingsshListener, err := network.Listen("tcp", ":"+strconv.Itoa(port)), which in turncreates a listener only on the Tailscale network.

ethanndickson reacted with heart emoji

@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch fromc9c1602 to07d5dc8CompareFebruary 27, 2025 12:52
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch 6 times, most recently fromae9e243 toaa1bd9dCompareFebruary 27, 2025 16:08
@matifali
Copy link
Member

/cherry-pick release/2.20

Change-Id: Ifd986b260f8ac317e37d65111cd4e0bd1dc38af8Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thethomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branch fromaa1bd9d toa9dec6bCompareFebruary 28, 2025 09:13
@ThomasK33ThomasK33 merged commitd0e2060 intomainMar 3, 2025
31 checks passed
@ThomasK33Graphite App
Copy link
MemberAuthor

Merge activity

  • Mar 2, 10:47 PM EST: A user merged this pull request withGraphite.

@ThomasK33ThomasK33 deleted the thomask33/02-19-fix_tailnet_update_workspaceagentsshport_to_22 branchMarch 3, 2025 03:47
gcp-cherry-pick-botbot pushed a commit that referenced this pull requestMar 3, 2025
Fixes:coder/internal#377Added an additional SSH listener on port 22, so the agent now listens on both, port one and port 22.---Change-Id: Ifd986b260f8ac317e37d65111cd4e0bd1dc38af8Signed-off-by: Thomas Kosiewski <tk@coder.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@ethanndicksonethanndicksonethanndickson approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent SSH server should listen on port 22 over tailnet
5 participants
@ThomasK33@matifali@spikecurtis@deansheather@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp