Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: force lowercase DNS hostnames for VPN#16613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/vpn-lowercase-dns
Feb 20, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedFeb 19, 2025•
edited
Loading

Closescoder/coder-desktop-macos#54

I've also double checked that agents with hyphens & underscores play nice once programmed, as do workspaces with hyphens:

$ ping6 main_agent-1.main-workspace.admin.coderPING6(56=40+8+8 bytes) fd60:627a:a42b:4e91:88c0:da4a:df4f:b54e --> fd60:627a:a42b:46d4:8b55:e549:e498:e6f5

also fine in Firefox & Safari, though I'm a little surprised underscores work.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedFeb 19, 2025•
edited
Loading

@ethanndicksonethanndickson changed the titlefix(vpn): force lowercase DNS hostnamesfix: force lowercase DNS hostnames for VPNFeb 19, 2025
@ethanndicksonethanndickson marked this pull request as ready for reviewFebruary 19, 2025 02:44
@ethanndicksonethanndickson changed the base branch frommain toethan/case-insensitive-unique-agent-namesFebruary 19, 2025 05:27
@ethanndicksonethanndicksonforce-pushed theethan/case-insensitive-unique-agent-names branch fromea0c978 to5241805CompareFebruary 19, 2025 05:30
@ethanndicksonethanndicksonforce-pushed theethan/case-insensitive-unique-agent-names branch from5241805 to566e3deCompareFebruary 19, 2025 05:50
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedFeb 20, 2025•
edited
Loading

Merge activity

  • Feb 19, 8:51 PM EST: A user started a stack merge that includes this pull request viaGraphite.
  • Feb 19, 8:53 PM EST:Graphite rebased this pull request as part of a merge.
  • Feb 19, 9:02 PM EST: A user merged this pull request withGraphite.

@ethanndicksonethanndickson changed the base branch fromethan/case-insensitive-unique-agent-names tographite-base/16613February 20, 2025 01:51
@ethanndicksonethanndickson changed the base branch fromgraphite-base/16613 tomainFebruary 20, 2025 01:51
@ethanndicksonethanndickson merged commit92870f0 intomainFeb 20, 2025
31 checks passed
@ethanndicksonethanndickson deleted the ethan/vpn-lowercase-dns branchFebruary 20, 2025 02:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DNS doesn't work for workspaces with uppercase letters in their names

3 participants

@ethanndickson@ThomasK33@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp