- Notifications
You must be signed in to change notification settings - Fork914
fix(flake.nix): add procps to nix dogfood image#16607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(flake.nix): add procps to nix dogfood image#16607
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Change-Id: I85432acc06a204229fa3675e0020bd3acacf775aSigned-off-by: Thomas Kosiewski <tk@coder.com>
| @@ -50,6 +50,10 @@ let | |||
| experimental-features = nix-command flakes | |||
| ''; | |||
| etcReleaseName = writeTextDir "etc/coderniximage-release" '' | |||
| 0.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: wonder if it would make sense to have some kind of versioning here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree. It would make sense to get some versioning here.
Right now, we're not versioning the dogfood images, so this file is mostly a stub/placeholder for the system info go library not to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could add the output ofgit describe --tags here, or we could consider versioning the dogfood images, in which case the image tag should go here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That or git SHA would probably be fine!
00e2703 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Add procps to flake.nix and release name to Docker image
Adds the
procpspackage to flake.nix to enable thefreecommand, and includes a release name file in the Docker image at/etc/coderniximage-release.Change-Id: I85432acc06a204229fa3675e0020bd3acacf775a
Signed-off-by: Thomas Kosiewskitk@coder.com