Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(provisioner/terraform/testdata): update provider versions, fix resource monitor tests#16601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intocolin/tf-1.10.5fromcj/colin/tf-1.10.5
Feb 18, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedFeb 18, 2025
edited
Loading

Updates to#16519

  • Fixes missing leading/ in volumes in resource monitor tests
  • Updates provider to>=2.0.0 in provider testdata
  • Fixes provider to required release version for resource monitors

matifali reacted with rocket emoji
@johnstcnjohnstcn self-assigned thisFeb 18, 2025
@johnstcnjohnstcn changed the titlechore(terraform/testdata): update provider versions, fix resource monitor testschore(provisioner/terraform/testdata): update provider versions, fix resource monitor testsFeb 18, 2025
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

❤️

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@@ -406,12 +406,12 @@ func TestConvertResources(t *testing.T) {
},
Volumes: []*proto.VolumeResourceMonitor{
{
Path: "volume2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did you catch it while reviewing or did any alarm go off?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the provider just complained

@johnstcnjohnstcn merged commitb770dc7 intocolin/tf-1.10.5Feb 18, 2025
36 of 38 checks passed
@johnstcnjohnstcn deleted the cj/colin/tf-1.10.5 branchFebruary 18, 2025 11:29
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@mtojekmtojekmtojek approved these changes

@defelmnqdefelmnqAwaiting requested review from defelmnq

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@dannykopping@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp