- Notifications
You must be signed in to change notification settings - Fork905
chore(provisioner/terraform/testdata): update provider versions, fix resource monitor tests#16601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
@@ -406,12 +406,12 @@ func TestConvertResources(t *testing.T) { | |||
}, | |||
Volumes: []*proto.VolumeResourceMonitor{ | |||
{ | |||
Path: "volume2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Did you catch it while reviewing or did any alarm go off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the provider just complained
b770dc7
intocolin/tf-1.10.5Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Updates to#16519
/
in volumes in resource monitor tests>=2.0.0
in provider testdata