- Notifications
You must be signed in to change notification settings - Fork913
fix: add link to troubleshooting#16592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Proabably no harm to get a quick FE review, but LGTM
| if (resource.agents) { | ||
| for (const agent of resource.agents) { | ||
| if (agent.troubleshooting_url) { | ||
| return agent.troubleshooting_url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
non-blocking: I can imagine a situation where a multi-agent workspace has a different troubleshooting URL for each agent. We might need some design changes to show multiple troubleshooting URLs though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought about this case! I concluded that having different Troubleshooting guides for various agents is an edge case.
42f6b71 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes:#14933
This PR extends theUnhealthy workspace notification with the troubleshooting link (if defined).