Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd): add stricter authorization for provisioners endpoint#16587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 3 commits intomainfrommafredri/feat-coderd-provisioner-auth
Feb 17, 2025

Conversation

mafredri
Copy link
Member

References#16558

@mafredrimafredri self-assigned thisFeb 17, 2025
johnstcn
johnstcn previously approved these changesFeb 17, 2025
Copy link
Member

@johnstcnjohnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM once tests are fixed.

EDIT: this might actually cause issues with user-owned provisioner daemons.

@mafredrimafredriforce-pushed themafredri/feat-coderd-provisioner-auth branch froma111e1e to2f4f1f7CompareFebruary 17, 2025 11:20
@mafredrimafredriforce-pushed themafredri/feat-coderd-provisioner-auth branch from2f4f1f7 to360f8a6CompareFebruary 17, 2025 11:20
@johnstcnjohnstcn dismissed theirstale reviewFebruary 17, 2025 11:49

user-local provisioner daemons

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Clarified interaction with user-scoped provisioners; existing tests still pass.

@mafredrimafredri merged commit7f061b9 intomainFeb 17, 2025
30 checks passed
@mafredrimafredri deleted the mafredri/feat-coderd-provisioner-auth branchFebruary 17, 2025 12:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mafredrimafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp