Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add oom/ood to notifications#16582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 6 commits intomainfrom16581-oom-ood-notif
Mar 5, 2025
Merged

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngertEdwardAngert commentedFeb 14, 2025
edited
Loading

  • add section or to another section: where the notifications show up/how to access

previews:

@EdwardAngertEdwardAngert added the docsArea: coder.com/docs labelFeb 14, 2025
@EdwardAngertEdwardAngert marked this pull request as ready for reviewFebruary 18, 2025 20:50
@EdwardAngert
Copy link
ContributorAuthor

  • BP terraform code for a template should be in templates; notifications page should link to extending templates > resource monitoring {new} | terraform code goes there (as explainingresources_monitoring)

@EdwardAngert
Copy link
ContributorAuthor

@defelmnq@stirby after talking with@bpmct about where this fits in, I put the tf block in a newresource monitoring page

I'd also like to add aResource monitoring section that introduces it inExtending templates - I don't think it's a blocker for this PR, but I want people to be able to find it

stirby reacted with thumbs up emoji

Copy link
Contributor

@defelmnqdefelmnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥 LGTM

Just a question - should we precise that the alerts are sent through SMTP ? (Means the deployment needs to have SMTP configured.)

Comment on lines 15 to 18
## Prerequisites

Notifications are sent through SMTP.
Configure Coder to [use an SMTP server](../../monitoring/notifications.md#smtp-email).
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@defelmnq definitely yes to letting them know it's through SMTP - how does this seem?

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMar 4, 2025
@matifalimatifali requested a review fromdefelmnqMarch 4, 2025 17:22
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelMar 5, 2025
@matifalimatifali merged commit9251e0d intomainMar 5, 2025
28 checks passed
@matifalimatifali deleted the 16581-oom-ood-notif branchMarch 5, 2025 09:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@defelmnqdefelmnqAwaiting requested review from defelmnq

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@EdwardAngert@defelmnq@matifali@stirby

[8]ページ先頭

©2009-2025 Movatter.jp