- Notifications
You must be signed in to change notification settings - Fork914
fix: show an error when a user doesn't have permission to view the health page#16580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aslilac left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Typically for this sort of thing, we prefer early returns over checks using ternaries. It helps keep the mainreturn
focused on rendering the page and makes it clearer when other states are special cases.
A good example of a page that does this right isGroupPage.tsx
While you're at it, could you turn the<Loader />
case into an early return as well?
Moved the checks for loading/error outside of the ternary, and then based onthis line from |
4732f08
intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.