- Notifications
You must be signed in to change notification settings - Fork928
fix: Guard against CLI cmd running after test exit#1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 10 commits intomainfrommafredri/fix-potential-cmd-running-after-test-exitMay 23, 2022
Merged
fix: Guard against CLI cmd running after test exit#1658
mafredri merged 10 commits intomainfrommafredri/fix-potential-cmd-running-after-test-exitMay 23, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
johnstcn approved these changesMay 23, 2022
Due to local SSH keys being given
Emyrk approved these changesMay 23, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* fix: Guard against CLI cmd running after test exit* fix: cli: avoid calling t.FailNow in non-test-main goroutine* fix: cli: server_test: avoid calling t.FailNow outside main goroutine* fix: cli: clitest_test: avoid calling t.FailNow outside main goroutine* fix: cli: list_test: avoid calling t.FailNow outside main goroutine* fix: TestGitSSH use-of-t-after-exit* fix: TestGitSSH "too many authentication failures"Due to local SSH keys being given* chore: clitest: fix TestCli* chore: Simplify TestTemplateInitCo-authored-by: Cian Johnston <cian@coder.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few cases of command potentially running after test exit. The require on test object can result in data race.