Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(provisioner): add support for presets to coder provisioners#16574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 8 commits intomainfromjjs/presets-provisioner
Feb 17, 2025

Conversation

SasSwart
Copy link
Contributor

@SasSwartSasSwart commentedFeb 14, 2025•
edited
Loading

This pull request adds support for presets to coder provisioners.
If a template defines presets using a compatible version of the provider, then this PR will allow those presets to be persisted to the control plane database for use in workspace creation.

@SasSwartSasSwart changed the titleAdd support for presets to coder provisionersfeat(provisioner): add support for presets to coder provisionersFeb 14, 2025
@SasSwartSasSwart marked this pull request as ready for reviewFebruary 14, 2025 13:44
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I encourage you to split out the provider changes.

required_providers {
coder = {
source = "coder/coder"
version = "0.22.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume this was copy-pasta, but we should update all of these.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

deferring this until we have a tagged release of the provider to update it to.

@SasSwartSasSwart merged commit46e04c6 intomainFeb 17, 2025
33 checks passed
@SasSwartSasSwart deleted the jjs/presets-provisioner branchFebruary 17, 2025 11:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@defelmnqdefelmnqAwaiting requested review from defelmnq

Assignees

@SasSwartSasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SasSwart@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp