Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: include origin in support link#16572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 9 commits intomainfrom15542-lins
Feb 14, 2025
Merged

fix: include origin in support link#16572

mtojek merged 9 commits intomainfrom15542-lins
Feb 14, 2025

Conversation

mtojek
Copy link
Member

Fixes:#15542

This PR ensures that a support link haswindow.origin prepended (if missing)

MrPeacockNLB reacted with hooray emoji
@mtojekmtojek self-assigned thisFeb 14, 2025
@mtojekmtojek marked this pull request as ready for reviewFebruary 14, 2025 11:47
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks Marcin ❤️ you are literally killing bugs. 🐛

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to have some unit tests forincludeOrigin, but LGTM otherwise 👍

@mtojek
Copy link
MemberAuthor

I'd like to have some unit tests forincludeOrigin

That's why I added the storybook case, but let me see if I can squeeze a simple unit test 👍

@mtojekmtojekenabled auto-merge (squash)February 14, 2025 12:17
@mtojekmtojek merged commit1c5a042 intomainFeb 14, 2025
29 of 30 checks passed
@mtojekmtojek deleted the 15542-lins branchFebruary 14, 2025 13:08
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@matifalimatifalimatifali approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix Coder support links relative path
3 participants
@mtojek@johnstcn@matifali

[8]ページ先頭

©2009-2025 Movatter.jp