- Notifications
You must be signed in to change notification settings - Fork905
chore: add"user_configs"
db table#16564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pls don't close my pr github |
6f61953
to0590d77
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
9041646
intomainUh oh!
There was an error while loading.Please reload this page.
ethanndickson commentedMar 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Since we're no longer sending the |
johnstcn commentedMar 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ethanndickson would it suffice to re-add the field in the /api/v2/users response but mark it as deprecated? EDIT: this was already done as part of this PR, the only other change was adding |
ethanndickson commentedMar 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think the change is fine honestly, but if it's breaking our own Coder integration (desktop), it's possible it could break someone else's. |
Uh oh!
There was an error while loading.Please reload this page.
Adds a
"user_configs"
tableMoves the data from the
"users"."theme_preference"
column to this new table as a bit of a proof of conceptThe idea is that this table will enable future feature development to have a nice spot to put user specific settings, like storing the state of dismissed notification banners, or other UI personalizations that we may add in the future. It could even be used to remember values from partial form completions, or all manner of other things, (and in a place where they can later be invalidated by the backend, rather than put in
localStorage
)