Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add"user_configs" db table#16564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 23 commits intomainfromlilac/user-configs
Mar 5, 2025
Merged

chore: add"user_configs" db table#16564

aslilac merged 23 commits intomainfromlilac/user-configs
Mar 5, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedFeb 13, 2025
edited
Loading

  • Adds a"user_configs" table

  • Moves the data from the"users"."theme_preference" column to this new table as a bit of a proof of concept

The idea is that this table will enable future feature development to have a nice spot to put user specific settings, like storing the state of dismissed notification banners, or other UI personalizations that we may add in the future. It could even be used to remember values from partial form completions, or all manner of other things, (and in a place where they can later be invalidated by the backend, rather than put inlocalStorage)

@aslilacaslilac requested a review fromEmyrkFebruary 18, 2025 17:39
@aslilacaslilac marked this pull request as ready for reviewFebruary 18, 2025 17:39
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelFeb 26, 2025
@aslilac
Copy link
MemberAuthor

pls don't close my pr github

@aslilacaslilac removed the staleThis issue is like stale bread. labelFeb 27, 2025
@aslilacaslilac requested review fromjohnstcn and removed request forEmyrkMarch 5, 2025 00:33
@aslilacaslilac merged commit9041646 intomainMar 5, 2025
35 checks passed
@aslilacaslilac deleted the lilac/user-configs branchMarch 5, 2025 17:46
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 5, 2025
@ethanndickson
Copy link
Member

ethanndickson commentedMar 6, 2025
edited
Loading

Since we're no longer sending thetheme_preference inapi/v2/users responses, should this be labelled as a breaking API change?
Context:coder/coder-desktop-macos#91

@johnstcn
Copy link
Member

johnstcn commentedMar 6, 2025
edited
Loading

@ethanndickson would it suffice to re-add the field in the /api/v2/users response but mark it as deprecated?

EDIT: this was already done as part of this PR, the only other change was addingomitempty.

@ethanndickson
Copy link
Member

ethanndickson commentedMar 6, 2025
edited
Loading

I think the change is fine honestly, but if it's breaking our own Coder integration (desktop), it's possible it could break someone else's.
..In saying that, I doubt people are actively consumingtheme_preference. If it does break something, it's probably just because they expected the field to be present like I did on desktop.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aslilac@ethanndickson@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp