- Notifications
You must be signed in to change notification settings - Fork928
fix: stop text from overflowing on delete org button#16549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <HorizontalSection | ||
| title="Settings" | ||
| description="Change or delete your organization." | ||
| > | ||
| <divcss={styles.dangerSettings}> | ||
| <divclassName="flex bg-surface-orange items-center justify-between border border-solid border-orange-600 rounded-[8px] p-3 pl-[18px] gap-2 flex-grow"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should actually avoid setting explicit styles with Tailwind as much as possible.
For rounded-, there actually will be some work in the future to update these in the tailwind.config. If this is set torounded-md it will automatically gets that update and therefore the consistency in the future.
Forpl-[18px], it would be better to just choose one of the closest classes either pl-4 or pl-5
In general, we should only use the explicit styling if that was a decision made in the Figma designs or the utility class options are really too different from what looks correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
1ce4dfe intomainUh oh!
There was an error while loading.Please reload this page.
Closes#16433
I also took the opportunity to convert the components to tailwind. Since there aren't designs for this piece of UI yet I tried to match it as closely as possible using the existing tailwind config