Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: display the correct response for coder list#16547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
evgeniy-scherbina merged 2 commits intomainfrom16312-coder-cli
Feb 13, 2025

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbinaevgeniy-scherbina commentedFeb 12, 2025
edited
Loading

Closes#16312

We intend to modify the behavior of the CLI handler based on the specified output format. However, the output format is currently only accessible within theOutputFormatter structure. Therefore, I propose extendingOutputFormatter by introducing a publicFormatID method, which will allow us to retrieve the format identifier and use it to customize the behavior of the CLI handler accordingly.

An alternative approach would be to make the implementation more generic. Instead of defining aFormatID method, we could introduce anIsMachineReadableFormat() bool method. This method would indicate whether the output format is machine-readable, allowing us to adjust the CLI handler's behavior accordingly.

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedFeb 12, 2025
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@evgeniy-scherbina
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor nit to add a comment 👍

@evgeniy-scherbinaevgeniy-scherbina merged commit981cf8c intomainFeb 13, 2025
30 checks passed
@evgeniy-scherbinaevgeniy-scherbina deleted the 16312-coder-cli branchFebruary 13, 2025 15:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: coder list -o json returns no value but a json is expected
2 participants
@evgeniy-scherbina@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp