- Notifications
You must be signed in to change notification settings - Fork925
chore: update table component and styles#16541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jaaydenh commentedFeb 12, 2025
- migrate styles to tailwind
- migrate to new Table component
| /> | ||
| <UserGroupsCell userGroups={member.groups} /> | ||
| <TableCell> | ||
| {member.user_id !== me.id && canEditMembers && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: I personally try to avoid conditional rendering with&& and instead will use a ternary. The reason being that I've been burned one too many times by the issue described in thePitfall note in theReact docs.
But I see&& used a lot within the code base, and this case doesn't fall into the issue so just wanted to bring it up just in case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ya you will notice this this pattern everywhere the component is used. I think right now ternaries only get used if there is something to return in both the true and false case.
ea1358c intomainUh oh!
There was an error while loading.Please reload this page.