Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli/server.go): allow the use of public OIDC clients#16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedFeb 7, 2025•
edited
Loading

Support public OIDC clients

  • Enables support for public OIDC clients by only checking for a client ID being set. This allows for confidential and public clients to be used with Coder's OIDC authentication.
  • Also adds a public client configuration to the development OIDC setup script.

Fixes#16135

Change-Id: Iadd85d40c2faa595a0498e25d3407a1f94b5c8a8
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewFebruary 7, 2025 11:52
@ThomasK33ThomasK33force-pushed the02-07-feat_cli_server.go_allow_the_use_of_public_oidc_clients branch from6c7d77a to9844582CompareFebruary 7, 2025 11:53
Change-Id: Iadd85d40c2faa595a0498e25d3407a1f94b5c8a8Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed the02-07-feat_cli_server.go_allow_the_use_of_public_oidc_clients branch from9844582 to3c81344CompareFebruary 7, 2025 11:58
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@ThomasK33ThomasK33 merged commit6a67e2e intomainFeb 7, 2025
31 checks passed
@ThomasK33ThomasK33 deleted the 02-07-feat_cli_server.go_allow_the_use_of_public_oidc_clients branchFebruary 7, 2025 13:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@ThomasK33ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support use of public OIDC clients
3 participants
@ThomasK33@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp