Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): add display of open ports in coder show#16464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/cli-show-ports
Feb 10, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedFeb 5, 2025•
edited
Loading

Relates to#16418 -- devcontainers will be shown in a similar manner.

Without ports (status quo):
Screenshot 2025-02-10 at 12 50 46

With ports:
Screenshot 2025-02-10 at 12 50 06

@johnstcnjohnstcnforce-pushed thecj/agent-containers-list branch from2c87b7e to8b081acCompareFebruary 10, 2025 11:06
Base automatically changed fromcj/agent-containers-list tomainFebruary 10, 2025 11:29
@johnstcnjohnstcn changed the titlefeat(cli): display open ports in coder showfeat(cli): add display of open ports in coder showFeb 10, 2025
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, nice work!

var wg sync.WaitGroup
var mu sync.Mutex
for _, res := range resources {
for _, agent := range res.Agents {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Still not used to seeing async for loops without temp variables, scary 😆

johnstcn reacted with laugh emoji
@johnstcnjohnstcn merged commit695d552 intomainFeb 10, 2025
32 checks passed
@johnstcnjohnstcn deleted the cj/cli-show-ports branchFebruary 10, 2025 13:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@dannykoppingdannykoppingAwaiting requested review from dannykopping

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp