Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add combobox for selecting claim field value for group/role idp sync#16459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 6 commits intomainfromjaaydenh/groups-roles-autocomplete
Feb 7, 2025

Conversation

jaaydenh
Copy link
Contributor

contributes tocoder/internal#330

This is a followup to#16335

This adds a combobox that swaps with the input for the idp group and idp role names when the sync field returns claim values from the claim field values endpoint. If no claim field values are returned then the input remains instead of the combobox.

Screenshot 2025-02-05 at 20 50 48Screenshot 2025-02-05 at 20 51 00

@jaaydenhjaaydenh self-assigned thisFeb 5, 2025
@jaaydenhjaaydenh changed the titlefeat: group/roles IDP sync - add combobox to select claim field value when sync field is setfeat: add combobox to select claim field value when sync field is set for group/role idp syncFeb 5, 2025
@jaaydenhjaaydenh changed the titlefeat: add combobox to select claim field value when sync field is set for group/role idp syncfeat: add combobox for selecting claim field value when sync field is set for group/role idp syncFeb 5, 2025
@jaaydenhjaaydenh changed the titlefeat: add combobox for selecting claim field value when sync field is set for group/role idp syncfeat: add combobox for selecting claim field value for group/role idp syncFeb 5, 2025
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

main thing I would like changed is the use ofonSuccess. we're gonna have to get rid of all those one day, I'd rather not make the list longer. 😅

otherwise looks good!

@jaaydenhjaaydenhforce-pushed thejaaydenh/groups-roles-autocomplete branch from97f619d to447cad7CompareFebruary 7, 2025 20:37
@jaaydenhjaaydenh merged commit7076c4e intomainFeb 7, 2025
30 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/groups-roles-autocomplete branchFebruary 7, 2025 21:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp