Feb 17, 2025 · Jan 24, 2025 · Jan 30, 2025 · Jan 30, 2025 · Jan 29, 2025 · Jan 29, 2025
diff --git a/coderd/agentapi/resourcesmonitor/resources_monitor.go b/coderd/agentapi/resourcesmonitor/resources_monitor.go
 }

 func NextState(c Config, oldState database.WorkspaceAgentMonitorState, states []State) database.WorkspaceAgentMonitorState {

 // If there are enough consecutive NOK states, we should be in an
 // alert state.
 consecutiveNOKs := slice.CountConsecutive(StateNOK, states...)
diff --git a/.../000293_workspace_monitors_state.down.sql → .../000294_workspace_monitors_state.down.sql b/.../000293_workspace_monitors_state.down.sql → .../000294_workspace_monitors_state.down.sql
diff --git a/...ns/000293_workspace_monitors_state.up.sql → ...ns/000294_workspace_monitors_state.up.sql b/...ns/000293_workspace_monitors_state.up.sql → ...ns/000294_workspace_monitors_state.up.sql
Original file line number	Diff line number	Diff line change
Expand Up		@@ -89,7 +89,6 @@ func CalculateVolumeUsageStates(
		}

		func NextState(c Config, oldState database.WorkspaceAgentMonitorState, states []State) database.WorkspaceAgentMonitorState {
DanielleMaywood marked this conversation as resolved. Show resolvedHide resolved Copy link Contributor dannykoppingFeb 17, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think we should consider moving the monitor state into`UNKNOWN` if all datapoints are unknown. Currently if a monitor gets into OK/NOK, and only receives empty datapoints from then on out, the state will never change and this will be difficult for operators/users to reason about unless they look at the agent logs specifically - which are hard to get to. This can be in a follow-up. Copy link ContributorAuthor DanielleMaywoodFeb 17, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I agree there should be more visibility if all datapoints are unknown. I don't believe we currently surface the monitor state anywhere so, at least for now, an`UNKNOWN` state wouldn't be visible to operators/users. We'd probably need to have a discussion on how to surface this information. Copy link Contributor dannykoppingFeb 17, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Let's document this in a follow-up issue.

		// If there are enough consecutive NOK states, we should be in an
		// alert state.
		consecutiveNOKs := slice.CountConsecutive(StateNOK, states...)
Expand Down