Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: Minor design adjustments#1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 4 commits intomainfrombq/minor-design-updates
May 20, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 20, 2022
@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerMay 20, 2022 19:28
@@ -42,6 +42,7 @@ const useFooterStyles = makeStyles((theme) => ({
flex: "0",
paddingTop: theme.spacing(2),
paddingBottom: theme.spacing(2),
marginTop: theme.spacing(3),
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The footer was very close to the content. Added some space.

"& td": {
paddingTop: 16,
paddingBottom: 16,
},
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Other tables were using that "manually" so I extracted them to be the standard.

@@ -48,6 +48,7 @@ export const WorkspaceBuildPage: React.FC = () => {

const useStyles = makeStyles((theme) => ({
title: {
marginTop: theme.spacing(5),
paddingTop: theme.spacing(5),
paddingBottom: theme.spacing(2),
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Add more spacing to the bottom of the Logs title.

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)May 20, 2022 19:30
@BrunoQuaresmaBrunoQuaresma merged commitb29a2df intomainMay 20, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/minor-design-updates branchMay 20, 2022 19:37
Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great ✔️

kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled left review comments

@presleyppresleyppresleyp approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@BrunoQuaresma@presleyp@greyscaled@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp