Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add terminal links#1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 2 commits intomainfromcode-asher/terminal-links
May 23, 2022
Merged

feat: add terminal links#1636

code-asher merged 2 commits intomainfromcode-asher/terminal-links
May 23, 2022

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedMay 20, 2022•
edited
Loading

terminal-links

Closes#760

f0ssel reacted with hooray emojif0ssel reacted with rocket emoji
@code-ashercode-asherforce-pushed thecode-asher/terminal-links branch from37f04bd toafa679aCompareMay 20, 2022 19:28
@code-ashercode-asher marked this pull request as ready for reviewMay 20, 2022 19:44
@code-ashercode-asher requested a review froma team as acode ownerMay 20, 2022 19:44
@code-asher
Copy link
MemberAuthor

code-asher commentedMay 20, 2022•
edited
Loading

It occurs to me that maybe I should only show the link if the status is "connected"?

@greyscaled
Copy link
Contributor

It occurs to me that maybe I should only show the link if the status is "connected"?

fair enough

code-asher reacted with rocket emoji

@ammario
Copy link
Member

ammario commentedMay 21, 2022•
edited
Loading

Why not make it a button 😬?

Also, I think it could be shortened "Open Terminal" or even just "Terminal".

f0ssel reacted with thumbs up emoji

@ammario
Copy link
Member

Also resolves#265

@code-ashercode-asherforce-pushed thecode-asher/terminal-links branch from55081d5 tod59d94dCompareMay 23, 2022 20:31
@code-asher
Copy link
MemberAuthor

code-asher commentedMay 23, 2022•
edited
Loading

Button and text change seems chill to me, gonna add a note on#1648

@code-ashercode-asherforce-pushed thecode-asher/terminal-links branch fromd59d94d to8a31fe9CompareMay 23, 2022 20:34
@code-ashercode-asher merged commitdd4bb07 intomainMay 23, 2022
@code-ashercode-asher deleted the code-asher/terminal-links branchMay 23, 2022 20:49
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the web terminal to the workspaces Application card
4 participants
@code-asher@greyscaled@ammario@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp