Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add 'email' field to notifications#16336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 4 commits intomainfromdm-add-owner-email-to-webhook-data
Jan 30, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedJan 29, 2025•
edited
Loading

Closescoder/internal#323

This PR adds anemail field to thedata.owner payload for workspace created and workspace manually updated notifications.

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consistent with other data fields hence 👍 from me.

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewJanuary 30, 2025 12:52
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Diff reviewed 👍

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall looks good, but I think it could use some hardening.

@DanielleMaywoodDanielleMaywood merged commitf651ab9 intomainJan 30, 2025
36 checks passed
@DanielleMaywoodDanielleMaywood deleted the dm-add-owner-email-to-webhook-data branchJanuary 30, 2025 17:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "email" property to webhook payload
3 participants
@DanielleMaywood@dannykopping@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp