Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(coderd/database/pubsub): ensure db closure on unhappy paths#16327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 1 commit intomainfrommafredri/test-fix-db-close
Jan 29, 2025

Conversation

mafredri
Copy link
Member

No description provided.

@mafredrimafredri self-assigned thisJan 29, 2025
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice find! I'm not sure if this is related tocoder/internal#327 but it definitely smells similar.

@mafredri
Copy link
MemberAuthor

Nice find! I'm not sure if this is related tocoder/internal#327 but it definitely smells similar.

Indeed it does, but there's probably yet another cause for that failure, unfortunately 😅

@mafredrimafredrienabled auto-merge (squash)January 29, 2025 14:47
@mafredrimafredri merged commitb77b543 intomainJan 29, 2025
33 checks passed
@mafredrimafredri deleted the mafredri/test-fix-db-close branchJanuary 29, 2025 14:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mafredrimafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp