NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

fix(provisioner/terraform/tfparse): allow empty values in coder_workspace_tag defaults#16303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 3 commits intomainfromcj/tfparse-allow-empty-defaults

Jan 28, 2025

Merged

fix(provisioner/terraform/tfparse): allow empty values in coder_workspace_tag defaults#16303

johnstcn merged 3 commits intomainfromcj/tfparse-allow-empty-defaults

Jan 28, 2025

Conversation

Copy link

Member

johnstcn commentedJan 27, 2025•
edited
Loading

This removes a check we previously had requiring all workspace tag values sniffed intfparse to have a non-empty value. This allows template authors to provide an initially empty value that is later overriden with tag values either in the request or passed in via template variables when importing the template.

Also updates documentation removing references to the non-empty default value requirement.

Also addresses an issue in our test code for starting a new external provisioner that causes an error if the test name is longer than 64 characters, which is longer than our DB schema allows.

Screen.Recording.2025-01-27.at.21.21.03.mov