Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Add (skipped)ptytest test that hangs on Intel Mac (and Windows)#1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mafredri
Copy link
Member

This (draft) PR adds a test that breaksptytest with unconsumed output on Intel Macs.

This is left open to inform / opportunity to investigate.

To reproduce:go test ./pty/ptytest -v -run=TestPtytest/Do_not_hang -timeout=5s

Here is the trace:trace.txt

// @coder/backend@Emyrk

@mafredri
Copy link
MemberAuthor

This was prompted by macOS test failures in#1591, and investigation using my macOS. The issue was narrowed down to not reading fromptytest specifically on Intel macOS, but the actual underlying issue remains unknown.

If we can confirm that the tests are correct, we could merge this in as skipped tests and open up a new issue to track the progress.

@ammario
Copy link
Member

What's the status of this PR?

@mafredrimafredriforce-pushed themafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed branch fromad76f64 to7692c5dCompareJune 7, 2022 09:57
@mafredrimafredriforce-pushed themafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed branch from21bcca7 to034cfa6CompareJune 7, 2022 10:03
@mafredrimafredri marked this pull request as ready for reviewJune 7, 2022 13:44
@mafredrimafredri changed the titlebug: Add test that breaks ptytest on Intel Macbug: Add test that breaksptytest on Intel Mac (and Windows)Jun 7, 2022
@mafredrimafredri requested review fromEmyrk anda teamJune 7, 2022 13:45
@mafredrimafredri changed the titlebug: Add test that breaksptytest on Intel Mac (and Windows)chore: Add (skipped) test that breaksptytest on Intel Mac (and Windows)Jun 7, 2022
@mafredri
Copy link
MemberAuthor

@ammario With the latest commits, this is now ready to be merged. Fixing this most likely requires a refactor (and decision on how to proceed) of theptytest package.

I've opened#2122 to track it.

@mafredrimafredriforce-pushed themafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed branch frome7fad00 to487f338CompareJune 7, 2022 13:48
@mafredrimafredri changed the titlechore: Add (skipped) test that breaksptytest on Intel Mac (and Windows)chore: Add (skipped)ptytest test that hangs on Intel Mac (and Windows)Jun 7, 2022
@mafredrimafredri merged commit6da4810 intomainJun 7, 2022
@mafredrimafredri deleted the mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed branchJune 7, 2022 14:08
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
…ows) (#1629)Co-authored-by: Steven Masley <stevenmasley@coder.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@ammario@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp