Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(flake.nix): switch dogfood dev image to buildNixShellImage from dockerTools#16223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ThomasK33
Copy link
Member

@ThomasK33ThomasK33 commentedJan 22, 2025•
edited
Loading

Replace Depot build action with Nix for Nix dogfood image builds

The dogfood Nix image is now built using Nix's native container tooling instead of Depot. This change:

  • Adds Nix setup steps to the GitHub Actions workflow
  • Removes the Dockerfile.nix in favor of a Nix-native container build
  • Updates the flake.nix to support building Docker images
  • Introduces a hash file to track Nix-related changes
  • Updates the vendorHash for Go dependencies

Change-Id: I4e011fe3a19d9a1375fbfd5223c910e59d66a5d9
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ThomasK33ThomasK33 marked this pull request as ready for reviewJanuary 22, 2025 10:34
@ThomasK33ThomasK33force-pushed the01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch from8226db4 to32d3437CompareJanuary 22, 2025 10:57
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but my knowledge of nix is minimal so maybe get someone else to review that part
Thanks!

Copy link
Member

@matifalimatifali left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a few suggestions, but LGTM.
Not anix expert, so I can not validate that part of the PR.

@matifali
Copy link
Member

Also.dockerignore may be unused now. It was perviously being used by docker build for nix image.

ThomasK33 reacted with thumbs up emoji

@ThomasK33ThomasK33force-pushed the01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch 2 times, most recently froma11ecf6 to56640adCompareJanuary 23, 2025 14:05
@ThomasK33ThomasK33force-pushed the01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch from56640ad toc18c4caCompareJanuary 24, 2025 11:40
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM apart from existing comments.

@ThomasK33ThomasK33force-pushed the01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch 5 times, most recently fromc1f3eaa tocb87bcfCompareJanuary 27, 2025 18:22
@ThomasK33ThomasK33force-pushed the01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch 3 times, most recently fromd38027c todafaf96CompareJanuary 28, 2025 14:34
…dockerToolsChange-Id: I4e011fe3a19d9a1375fbfd5223c910e59d66a5d9Signed-off-by: Thomas Kosiewski <tk@coder.com>
Change-Id: Id4cb8943ae1bf40d0b24eb899bd58801f28e851aSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed the01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branch fromdafaf96 to0ed90c6CompareJanuary 28, 2025 14:57
@ThomasK33ThomasK33 merged commit1336925 intomainJan 28, 2025
38 checks passed
@ThomasK33ThomasK33 deleted the 01-22-feat_flake.nix_switch_dogfood_dev_image_to_buildnixshellimage_from_dockertools branchJanuary 28, 2025 15:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@matifalimatifalimatifali approved these changes

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis is a code owner

Assignees

@ThomasK33ThomasK33

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ThomasK33@matifali@dannykopping@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp