- Notifications
You must be signed in to change notification settings - Fork920
refactor: replace MUI button on TopbarButton#16212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@BrunoQuaresma did the appearance of the UI change at all because of these changes? if so it could be useful to see some screenshots. |
Yes, they changed slightly. It would be better for you to review them in Chromatic:Chromatic Link. |
| onClick={() => handleAction()} | ||
| data-testid="workspace-stop-button" | ||
| > | ||
| <CircleStopIcon /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you link to the Figma designs you are referencing for these changes? I see a the square stop icon being used instead of the circle stop icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There aren’t any design references; I’m simply replacing the MUI buttons and keeping design changes minimal. Waiting for designs for every page or component with buttons could take years to complete.
Regarding the icon, I switched toCircleStopIcon for consistency since we useCirclePlayIcon for the start action. However, if you feel this change is too disruptive, I can revert it and restore the old square icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just feel like its harder to see the circle icons compared to without the circles but we can always get christin's opinion at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let’s defer to the design master@chrifro for their expert opinion 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
6cbc44b intomainUh oh!
There was an error while loading.Please reload this page.
Related to#14978