Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(codersdk/healthsdk): update docs url path for health errors#16180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit into2025-01-16-linkfixfromcj/healthsdk/docs-url
Jan 17, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJan 17, 2025
edited
Loading

Updates the URL suffix we append to DeploymentValues.DocsURL to generate stable links for health messages.
Adds missing test case coverage for custom docs URL from deployment values.

@johnstcnjohnstcn self-assigned thisJan 17, 2025
@EdwardAngertEdwardAngert changed the base branch frommain to2025-01-16-linkfixJanuary 17, 2025 17:21
@johnstcnjohnstcn merged commit55351f6 into2025-01-16-linkfixJan 17, 2025
23 of 32 checks passed
@johnstcnjohnstcn deleted the cj/healthsdk/docs-url branchJanuary 17, 2025 17:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 17, 2025
@matifali
Copy link
Member

/cherry-pick release/2.18

@johnstcn
Copy link
MemberAuthor

/cherry-pick release/2.18

not this one!

@matifali
Copy link
Member

@johnstcn Oops. Let this be a test for the bot. I will close the PR the bot opens.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredriAwaiting requested review from mafredri

1 more reviewer

@EdwardAngertEdwardAngertEdwardAngert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn@matifali@EdwardAngert

[8]ページ先頭

©2009-2025 Movatter.jp