- Notifications
You must be signed in to change notification settings - Fork1k
docs: fix broken links#16179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
docs: fix broken links#16179
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Updates the URL suffix we append to DeploymentValues.DocsURL to generatestable links for health messages.Adds missing test case coverage for custom docs URL from deploymentvalues.
/cherry-pick release/2.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks Edward.
| -pattern:"code.visualstudio.com" | ||
| -pattern:"www.emacswiki.org" | ||
| -pattern:"linux.die.net/man" | ||
| -pattern:"www.gnu.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wonder why we need to ignore this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that site probably blocks however linkspector is checking responses, so even though the site is there, the check fails:https://github.com/coder/coder/actions/runs/12834052725/job/35790477857#step:5:240
| for the repositories you want to scan. | ||
| 1. Create a Coder[token](../../reference/cli/tokens_create.md#tokens-create) with a user that has the[`owner`](../users#roles) role. | ||
| 1. Create a Coder[token](../../reference/cli/tokens_create.md#tokens-create) with a user that has the[`owner`](../users/index.md#roles) role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is interesting find. I wonder why it was not flagged by the linkchecker.
4f438e7 intomainUh oh!
There was an error while loading.Please reload this page.
Cherry-pick failed with |
Post-merge approval 👍 |
No description provided.