Jan 17, 2025 · Jan 17, 2025 · Jan 17, 2025 · Jan 17, 2025 · Jan 17, 2025
diff --git a/Makefile b/Makefile
 # NOTE: we set --memory to the same size as a GitHub runner.
 test-postgres-docker:
 docker rm -f test-postgres-docker-${POSTGRES_VERSION} || true

 # Try pulling up to three times to avoid CI flakes.
 docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} || \
 docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} || \
 docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION}

 # Make sure to not overallocate work_mem and max_connections as each
 # connection will be allowed to use this much memory. Try adjusting
 # shared_buffers instead, if needed.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -864,6 +864,12 @@ test-migrations: test-postgres-docker
		# NOTE: we set --memory to the same size as a GitHub runner.
		test-postgres-docker:
		docker rm -f test-postgres-docker-${POSTGRES_VERSION} \|\| true

		# Try pulling up to three times to avoid CI flakes.
		docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} \|\| \
		docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} \|\| \
		docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION}
Copy link Member johnstcnJan 17, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. That'd work, but maybe we could add a utility script that doe something like this: `# Try pulling up to three times to avoid CI flakes.for attempt in {1..3}; doif [ ! docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} ]; then echo "Failed to pull image, retrying..."; sleep 1;else break;fidone` Copy link MemberAuthor mafredriJan 17, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ok, that'd be nicer for sure, I was just lazy. I adapted it a bit to make sure we don't print retrying after we don't retry any more 👍🏻 johnstcn reacted with thumbs up emoji

		# Make sure to not overallocate work_mem and max_connections as each
		# connection will be allowed to use this much memory. Try adjusting
		# shared_buffers instead, if needed.
Expand Down