- Notifications
You must be signed in to change notification settings - Fork923
test(Makefile): retry pulling postgres in test-postgres-docker#16178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
4814457 to196d2afCompareMakefile Outdated
| # Try pulling up to three times to avoid CI flakes. | ||
| docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} || \ | ||
| docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} || \ | ||
| docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That'd work, but maybe we could add a utility script that doe something like this:
# Try pulling up to three times to avoid CI flakes.for attempt in {1..3}; doif [ ! docker pull gcr.io/coder-dev-1/postgres:${POSTGRES_VERSION} ]; then echo "Failed to pull image, retrying..."; sleep 1;else break;fidoneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, that'd be nicer for sure, I was just lazy. I adapted it a bit to make sure we don't print retrying after we don't retry any more 👍🏻
d57941d to220a38aCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
08ffcb7 intomainUh oh!
There was an error while loading.Please reload this page.
https://github.com/coder/coder/actions/runs/12796458261/job/35676174099